1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 19:07:35 +00:00

LibGfx+LibWeb: Add ImmutableBitmap for images bitmap caching in painter

Before this change, we used Gfx::Bitmap to represent both decoded
images that are not going to be mutated and bitmaps corresponding
to canvases that could be mutated.

This change introduces a wrapper for bitmaps that are not going to be
mutated, so the painter could do caching: texture caching in the case
of GPU painter and potentially scaled bitmap caching in the case of CPU
painter.
This commit is contained in:
Aliaksandr Kalenik 2023-11-24 14:45:45 +01:00 committed by Andreas Kling
parent abcf71a8ca
commit f4a5c136c3
24 changed files with 146 additions and 35 deletions

View file

@ -60,6 +60,7 @@ set(SOURCES
ImageFormats/WebPLoader.cpp
ImageFormats/WebPLoaderLossless.cpp
ImageFormats/WebPLoaderLossy.cpp
ImmutableBitmap.cpp
Painter.cpp
Palette.cpp
Path.cpp

View file

@ -9,6 +9,7 @@
namespace Gfx {
class Bitmap;
class ImmutableBitmap;
class CharacterBitmap;
class Color;

View file

@ -0,0 +1,24 @@
/*
* Copyright (c) 2023, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibGfx/ImmutableBitmap.h>
namespace Gfx {
static size_t s_next_immutable_bitmap_id = 0;
NonnullRefPtr<ImmutableBitmap> ImmutableBitmap::create(NonnullRefPtr<Bitmap> bitmap)
{
return adopt_ref(*new ImmutableBitmap(move(bitmap)));
}
ImmutableBitmap::ImmutableBitmap(NonnullRefPtr<Bitmap> bitmap)
: m_bitmap(move(bitmap))
, m_id(s_next_immutable_bitmap_id++)
{
}
}

View file

@ -0,0 +1,40 @@
/*
* Copyright (c) 2023, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/Forward.h>
#include <AK/RefCounted.h>
#include <LibGfx/Bitmap.h>
#include <LibGfx/Forward.h>
#include <LibGfx/Rect.h>
namespace Gfx {
class ImmutableBitmap final : public RefCounted<ImmutableBitmap> {
public:
static NonnullRefPtr<ImmutableBitmap> create(NonnullRefPtr<Bitmap> bitmap);
~ImmutableBitmap() = default;
Bitmap const& bitmap() const { return *m_bitmap; }
size_t width() const { return m_bitmap->width(); }
size_t height() const { return m_bitmap->height(); }
IntRect rect() const { return m_bitmap->rect(); }
IntSize size() const { return m_bitmap->size(); }
size_t id() const { return m_id; }
private:
NonnullRefPtr<Bitmap> m_bitmap;
size_t m_id;
explicit ImmutableBitmap(NonnullRefPtr<Bitmap> bitmap);
};
}