RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:17:45 +00:00
Code Issues Activity Actions

LibJS: Add PrimitiveString::is_empty() and use it

Browse source 
If we're only interested in whether the string is empty, we can skip the
conversion from UTF-16 to UTF-8.
This commit is contained in:
Andreas Kling 2022-07-17 21:08:53 +02:00
parent 32480fbeb9
commit f4c68eb0a4
3 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/Runtime/PrimitiveString.cpp
View file

@ -32,6 +32,15 @@ PrimitiveString::~PrimitiveString()
vm().string_cache().remove(m_utf8_string);
}
bool PrimitiveString::is_empty() const
{
if (m_has_utf16_string)
return m_utf16_string.is_empty();
if (m_has_utf8_string)
return m_utf8_string.is_empty();
VERIFY_NOT_REACHED();
}
String const& PrimitiveString::string() const
{
if (!m_has_utf8_string) {

2
Userland/Libraries/LibJS/Runtime/PrimitiveString.h
View file

@ -24,6 +24,8 @@ public:
PrimitiveString(PrimitiveString const&) = delete;
PrimitiveString& operator=(PrimitiveString const&) = delete;
bool is_empty() const;
String const& string() const;
bool has_utf8_string() const { return m_has_utf8_string; }

2
Userland/Libraries/LibJS/Runtime/Value.cpp
View file

@ -382,7 +382,7 @@ bool Value::to_boolean() const
return false;
return m_value.as_double != 0;
case Type::String:
return !m_value.as_string->string().is_empty();
return !m_value.as_string->is_empty();
case Type::Symbol:
return true;
case Type::BigInt: