RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:17:44 +00:00
Code Issues Activity Actions

LibSymbolication: Return empty value on error

Browse source 
This was probably the intended behavior, but a return statement was
missing.
This commit is contained in:
Rodrigo Tobar 2021-09-27 23:50:09 +08:00 • committed by Andreas Kling
parent 683bf558e4
commit f4ebcf4867
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibSymbolication/Symbolication.cpp
View file

@ -72,7 +72,7 @@ Optional<Symbol> symbolicate(String const& path, FlatPtr address)
if (!elf->is_valid()) { if (!elf->is_valid()) {
dbgln("ELF not valid: {}", path); dbgln("ELF not valid: {}", path);
s_cache.set(path, {}); s_cache.set(path, {});
{}; return {};
} }
auto cached_elf = make<CachedELF>(mapped_file.release_value(), make<Debug::DebugInfo>(*elf), move(elf)); auto cached_elf = make<CachedELF>(mapped_file.release_value(), make<Debug::DebugInfo>(*elf), move(elf));
s_cache.set(path, move(cached_elf)); s_cache.set(path, move(cached_elf));