RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:27:43 +00:00
Code Issues Activity Actions

LibWeb: Don't trigger page_did_layout() on non-active documents

Browse source 
PageHost assumes page_did_layout() to be called when the layout
of the active document changes, however, it seems that sometimes
the layout can change on another document before the layout of
the active document has been calculated. This leads to a VERIFY()
being hit.

This commit now makes it so page_did_layout() is only called when
the document is the active document.

Fixes #15328
This commit is contained in:
MacDue 2022-09-23 23:15:28 +01:00 • committed by Andreas Kling
parent 29260d1480
commit f5052e5017
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -816,7 +816,7 @@ void Document::update_layout()
browsing_context()->set_needs_display();
if (browsing_context()->is_top_level()) {
if (browsing_context()->is_top_level() && browsing_context()->active_document() == this) {
if (auto* page = this->page())
page->client().page_did_layout();
}