RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:57:44 +00:00
Code Issues Activity Actions

HackStudio: Fix crash when requesting parameter list

Browse source 
When requesting a parameter hint message with `Ctrl + p` in a file that
doesn't have a language server, we would crash.

Now, rather than verifying that we have a language server, we return
early if we don't have one.
This commit is contained in:
Harrison Marshall 2022-02-14 23:06:11 +11:00 • committed by Andreas Kling
parent d345a3689f
commit f538545987
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/DevTools/HackStudio/Editor.cpp
View file

@ -689,7 +689,8 @@ void Editor::keydown_event(GUI::KeyEvent& event)
void Editor::handle_function_parameters_hint_request() void Editor::handle_function_parameters_hint_request()
{ {
VERIFY(m_language_client); if (!m_language_client)
return;
m_language_client->on_function_parameters_hint_result = [this](Vector<String> const& params, size_t argument_index) { m_language_client->on_function_parameters_hint_result = [this](Vector<String> const& params, size_t argument_index) {
dbgln("on_function_parameters_hint_result"); dbgln("on_function_parameters_hint_result");