RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:58:11 +00:00
Code Issues Activity Actions

LibJS: Implement the import assertions proposal

Browse source 
The hard part of parsing them in import statements and calls was already
done so this is just removing some check which threw before on
assertions. And filtering the assertions based on the result of a new
host hook.
This commit is contained in:
davidot 2022-01-27 02:44:03 +01:00 • committed by Linus Groh
parent e0e4ead2c8
commit f568939568
11 changed files with 270 additions and 83 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibJS/CyclicModule.cpp
View file

@ -10,7 +10,7 @@
namespace JS {
CyclicModule::CyclicModule(Realm& realm, StringView filename, bool has_top_level_await, Vector<FlyString> requested_modules)
CyclicModule::CyclicModule(Realm& realm, StringView filename, bool has_top_level_await, Vector<ModuleRequest> requested_modules)
: Module(realm, filename)
, m_requested_modules(move(requested_modules))
, m_has_top_level_await(has_top_level_await)
@ -93,7 +93,14 @@ ThrowCompletionOr<u32> CyclicModule::inner_module_linking(VM& vm, Vector<Module*
// 8. Append module to stack.
stack.append(this);
dbgln_if(JS_MODULE_DEBUG, "[JS MODULE] module: {} has requested modules: [{}]", filename(), String::join(",", m_requested_modules));
#if JS_MODULE_DEBUG
StringBuilder request_module_names;
for (auto& module_request : m_requested_modules) {
request_module_names.append(module_request.module_specifier);
request_module_names.append(", ");
}
dbgln_if(JS_MODULE_DEBUG, "[JS MODULE] module: {} has requested modules: [{}]", filename(), request_module_names.string_view());
#endif
// 9. For each String required of module.[[RequestedModules]], do
for (auto& required_string : m_requested_modules) {
@ -300,8 +307,7 @@ ThrowCompletionOr<u32> CyclicModule::inner_module_evaluation(VM& vm, Vector<Modu
stack.append(this);
// 11. For each String required of module.[[RequestedModules]], do
for (auto& required_string : m_requested_modules) {
ModuleRequest required { required_string };
for (auto& required : m_requested_modules) {
// a. Let requiredModule be ! HostResolveImportedModule(module, required).
auto* required_module = MUST(vm.host_resolve_imported_module(this, required)).ptr();