RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-05 15:27:35 +00:00
Code Issues Activity Actions

LibWeb: Parse the CSS opacity property with strtof() for now

Browse source 
With the new parser, we started interpreting the `opacity` property as a
string value, which made it turn into `auto` and so anything with
opacity ended up not visible (e.g the header on google.com)

This patch restores our old behavior for `opacity` by interpreting it
as a numeric value with optional decimals.
This commit is contained in:
Andreas Kling 2021-08-20 15:43:01 +02:00
parent ed7a2f21ff
commit f58e2350dc
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -2869,6 +2869,12 @@ RefPtr<StyleValue> Parser::parse_css_value(ParsingContext const& context, Proper
} }
} }
// FIXME: This is a hack for the `opacity` property which should really take an <alpha-value>
if (property_id == PropertyID::Opacity && component_value.is(Token::Type::Number)) {
String string = component_value.token().number_string_value();
return LengthStyleValue::create(Length::make_px(strtof(string.characters(), nullptr)));
}
if (auto builtin_or_dynamic = parse_builtin_or_dynamic_value(context, component_value)) if (auto builtin_or_dynamic = parse_builtin_or_dynamic_value(context, component_value))
return builtin_or_dynamic; return builtin_or_dynamic;