RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 08:28:11 +00:00
Code Issues Activity Actions

LibWeb: Set a detach key for ArrayBuffers returned from WASM

Browse source 
As required by the specification:
`Set buffer.[[ArrayBufferDetachKey]] to "WebAssembly.Memory".`
This commit is contained in:
Idan Horowitz 2021-06-11 00:59:24 +03:00 • committed by Linus Groh
parent a64089092f
commit f5a978c1aa
3 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/ArrayBuffer.cpp
View file

@ -37,4 +37,10 @@ ArrayBuffer::~ArrayBuffer()
{
}
void ArrayBuffer::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
visitor.visit(m_detach_key);
}
}

4
Userland/Libraries/LibJS/Runtime/ArrayBuffer.h
View file

@ -28,10 +28,14 @@ public:
const ByteBuffer& buffer() const { return buffer_impl(); }
Value detach_key() const { return m_detach_key; }
void set_detach_key(Value detach_key) { m_detach_key = detach_key; }
void detach_buffer() { m_buffer = Empty {}; }
bool is_detached() const { return m_buffer.has<Empty>(); }
private:
virtual void visit_edges(Visitor&) override;
ByteBuffer& buffer_impl()
{
ByteBuffer* ptr { nullptr };

4
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyObject.cpp
View file

@ -441,7 +441,9 @@ JS_DEFINE_NATIVE_GETTER(WebAssemblyMemoryObject::buffer)
if (!memory)
return JS::js_undefined();
return JS::ArrayBuffer::create(global_object, &memory->data());
auto array_buffer = JS::ArrayBuffer::create(global_object, &memory->data());
array_buffer->set_detach_key(JS::js_string(vm, "WebAssembly.Memory"));
return array_buffer;
}
}