RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:08:11 +00:00
Code Issues Activity Actions

Kernel/Devices: Defer creation of SysFS component after the constructor

Browse source 
Instead of doing so in the constructor, let's do immediately after the
constructor, so we can safely pass a reference of a Device, so the
SysFSDeviceComponent constructor can use that object to identify whether
it's a block device or a character device.
This allows to us to not hold a device in SysFSDeviceComponent with a
RefPtr.
Also, we also call the before_removing method in both SlavePTY::unref
and File::unref, so because Device has that method being overrided, it
can ensure the device is removed always cleanly.
This commit is contained in:
Liav A 2021-09-10 14:44:46 +03:00 • committed by Andreas Kling
parent c545d4ffcb
commit f5de4f24b2
41 changed files with 142 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/SysFS.h
View file

@ -34,12 +34,12 @@ class SysFSDeviceComponent final
public:
static NonnullRefPtr<SysFSDeviceComponent> must_create(Device const&);
Device const& device() const { return *m_associated_device; }
bool is_block_device() { return m_block_device; }
private:
explicit SysFSDeviceComponent(Device const&);
IntrusiveListNode<SysFSDeviceComponent, NonnullRefPtr<SysFSDeviceComponent>> m_list_node;
RefPtr<Device> m_associated_device;
bool m_block_device;
};
class SysFSDevicesDirectory final : public SysFSDirectory {