mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 05:27:43 +00:00
Kernel/Devices: Defer creation of SysFS component after the constructor
Instead of doing so in the constructor, let's do immediately after the constructor, so we can safely pass a reference of a Device, so the SysFSDeviceComponent constructor can use that object to identify whether it's a block device or a character device. This allows to us to not hold a device in SysFSDeviceComponent with a RefPtr. Also, we also call the before_removing method in both SlavePTY::unref and File::unref, so because Device has that method being overrided, it can ensure the device is removed always cleanly.
This commit is contained in:
parent
c545d4ffcb
commit
f5de4f24b2
41 changed files with 142 additions and 57 deletions
|
@ -32,9 +32,10 @@ public:
|
|||
virtual void start_request(AsyncBlockDeviceRequest&) override;
|
||||
virtual String storage_name() const override;
|
||||
|
||||
private:
|
||||
// FIXME: We expose this constructor to make try_create_device helper to work
|
||||
SATADiskDevice(const AHCIController&, const AHCIPort&, size_t sector_size, u64 max_addressable_block);
|
||||
|
||||
private:
|
||||
// ^DiskDevice
|
||||
virtual StringView class_name() const override;
|
||||
WeakPtr<AHCIPort> m_port;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue