RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:27:35 +00:00
Code Issues Activity Actions

Kernel/Storage: Add AssertSizes to AHCI structs

Browse source
This commit is contained in:
Sönke Holz 2024-02-20 23:43:02 +01:00 • committed by Andrew Kaster
parent f85099ea47
commit f6151b3c9e
1 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Kernel/Devices/Storage/ATA/AHCI/Definitions.h
View file

@ -6,6 +6,7 @@
#pragma once #pragma once
#include <AK/StdLibExtraDetails.h>
#include <AK/Types.h> #include <AK/Types.h>
namespace Kernel::FIS { namespace Kernel::FIS {
@ -38,6 +39,7 @@ struct [[gnu::packed]] Header {
u8 fis_type; u8 fis_type;
u8 port_muliplier; u8 port_muliplier;
}; };
static_assert(AssertSize<Header, 2>());
} }
@ -56,6 +58,7 @@ struct [[gnu::packed]] Register {
u8 control; u8 control;
u32 reserved; u32 reserved;
}; };
static_assert(AssertSize<Register, 5 * 4>());
}; };
@ -72,6 +75,7 @@ struct [[gnu::packed]] Register {
u16 count; u16 count;
u8 reserved2[6]; u8 reserved2[6];
}; };
static_assert(AssertSize<Register, 5 * 4>());
struct [[gnu::packed]] SetDeviceBits { struct [[gnu::packed]] SetDeviceBits {
Header header; Header header;
@ -79,11 +83,13 @@ struct [[gnu::packed]] SetDeviceBits {
u8 error; u8 error;
u32 protocol_specific; u32 protocol_specific;
}; };
static_assert(AssertSize<SetDeviceBits, 2 * 4>());
struct [[gnu::packed]] DMAActivate { struct [[gnu::packed]] DMAActivate {
Header header; Header header;
u16 reserved; u16 reserved;
}; };
static_assert(AssertSize<DMAActivate, 1 * 4>());
struct [[gnu::packed]] PIOSetup { struct [[gnu::packed]] PIOSetup {
Header header; Header header;
@ -99,6 +105,7 @@ struct [[gnu::packed]] PIOSetup {
u16 transfer_count; u16 transfer_count;
u16 reserved3; u16 reserved3;
}; };
static_assert(AssertSize<PIOSetup, 5 * 4>());
} }
@ -109,6 +116,7 @@ struct [[gnu::packed]] Data {
u16 reserved; u16 reserved;
u32 data[]; u32 data[];
}; };
static_assert(AssertSize<Data, 1 * 4>());
struct [[gnu::packed]] BISTActivate { struct [[gnu::packed]] BISTActivate {
}; };
@ -122,6 +130,7 @@ struct [[gnu::packed]] DMASetup {
u32 dma_transfer_count; u32 dma_transfer_count;
u32 reserved3; u32 reserved3;
}; };
static_assert(AssertSize<DMASetup, 7 * 4>());
} }
@ -263,6 +272,7 @@ struct [[gnu::packed]] HBADefinedCapabilities {
bool aggressive_device_sleep_management_supported : 1 { false }; bool aggressive_device_sleep_management_supported : 1 { false };
bool devsleep_entrance_from_slumber_only : 1 { false }; bool devsleep_entrance_from_slumber_only : 1 { false };
}; };
static_assert(AssertSize<HBADefinedCapabilities, 20>());
enum class DeviceDetectionInitialization { enum class DeviceDetectionInitialization {
NoActionRequested, NoActionRequested,
@ -381,6 +391,7 @@ struct [[gnu::packed]] PortRegisters {
u8 reserved2[0x70 - 0x48]; u8 reserved2[0x70 - 0x48];
u8 vs[16]; /* Port x Vendor Specific */ u8 vs[16]; /* Port x Vendor Specific */
}; };
static_assert(AssertSize<PortRegisters, 0x80>());
struct [[gnu::packed]] GenericHostControl { struct [[gnu::packed]] GenericHostControl {
u32 cap; /* Host Capabilities */ u32 cap; /* Host Capabilities */
@ -395,6 +406,7 @@ struct [[gnu::packed]] GenericHostControl {
u32 cap2; /* Host Capabilities Extended */ u32 cap2; /* Host Capabilities Extended */
u32 bohc; /* BIOS/OS Handoff Control and Status */ u32 bohc; /* BIOS/OS Handoff Control and Status */
}; };
static_assert(AssertSize<GenericHostControl, 0x2c>());
struct [[gnu::packed]] HBA { struct [[gnu::packed]] HBA {
GenericHostControl control_regs; GenericHostControl control_regs;
@ -403,6 +415,8 @@ struct [[gnu::packed]] HBA {
u8 vendor_specific[96]; u8 vendor_specific[96];
PortRegisters port_regs[]; PortRegisters port_regs[];
}; };
static_assert(AssertSize<HBA, 0x100>());
static_assert(__builtin_offsetof(HBA, port_regs[32]) == 0x1100);
struct [[gnu::packed]] CommandHeader { struct [[gnu::packed]] CommandHeader {
u16 attributes; u16 attributes;
@ -412,6 +426,7 @@ struct [[gnu::packed]] CommandHeader {
u32 ctbau; /* Command Table Descriptor Base Address Upper 32-bits */ u32 ctbau; /* Command Table Descriptor Base Address Upper 32-bits */
u32 reserved[4]; u32 reserved[4];
}; };
static_assert(AssertSize<CommandHeader, 8 * 4>());
struct [[gnu::packed]] PhysicalRegionDescriptor { struct [[gnu::packed]] PhysicalRegionDescriptor {
u32 base_low; u32 base_low;
@ -419,6 +434,7 @@ struct [[gnu::packed]] PhysicalRegionDescriptor {
u32 reserved; u32 reserved;
u32 byte_count; /* Bit 31 - Interrupt completion, Bit 0 to 21 - Data Byte Count */ u32 byte_count; /* Bit 31 - Interrupt completion, Bit 0 to 21 - Data Byte Count */
}; };
static_assert(AssertSize<PhysicalRegionDescriptor, 4 * 4>());
struct [[gnu::packed]] CommandTable { struct [[gnu::packed]] CommandTable {
u8 command_fis[64]; u8 command_fis[64];
@ -426,4 +442,6 @@ struct [[gnu::packed]] CommandTable {
u8 reserved[32]; u8 reserved[32];
PhysicalRegionDescriptor descriptors[]; PhysicalRegionDescriptor descriptors[];
}; };
static_assert(AssertSize<CommandTable, 0x80>());
} }