From f630d0f095552196199c7334973f57dd7d44f352 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 7 Mar 2022 17:44:27 +0100 Subject: [PATCH] Kernel: Mark sys$realpath() as not needing the big lock This syscall doesn't access any data that was implicitly protected by the big lock. --- Kernel/API/Syscall.h | 2 +- Kernel/Syscalls/realpath.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index 9fbd375c79..fc59cbe901 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -144,7 +144,7 @@ enum class NeedsBigProcessLock { S(pread, NeedsBigProcessLock::Yes) \ S(readlink, NeedsBigProcessLock::Yes) \ S(readv, NeedsBigProcessLock::Yes) \ - S(realpath, NeedsBigProcessLock::Yes) \ + S(realpath, NeedsBigProcessLock::No) \ S(recvfd, NeedsBigProcessLock::Yes) \ S(recvmsg, NeedsBigProcessLock::Yes) \ S(rename, NeedsBigProcessLock::Yes) \ diff --git a/Kernel/Syscalls/realpath.cpp b/Kernel/Syscalls/realpath.cpp index e1feed2eb7..bda04d2e8a 100644 --- a/Kernel/Syscalls/realpath.cpp +++ b/Kernel/Syscalls/realpath.cpp @@ -13,7 +13,7 @@ namespace Kernel { ErrorOr Process::sys$realpath(Userspace user_params) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::rpath)); auto params = TRY(copy_typed_from_user(user_params));