RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 02:38:13 +00:00
Code Issues Activity Actions

LibJS: Add the ToTemporalTime AO and stub the ParseTemporalTimeString AO

Browse source 
This AO is required for a bunch of PlainTime related methods.

As part of this change the `TemporalTime` record was renamed to
`UnregulatedTemporalTime` and a new `TemporalTime` record that matches
the other Temporal parse result records was added. This also has the
added benefit of getting rid of a would be round-trip cast from integer
to double and back in `ParseTemporalTimeString`.
This commit is contained in:
Idan Horowitz 2021-08-27 18:02:37 +03:00 • committed by Linus Groh
parent 32fc81c186
commit f6370fe3f7
5 changed files with 147 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTime.cpp
View file

@ -103,10 +103,8 @@ Optional<ISODateTime> interpret_temporal_date_time_fields(GlobalObject& global_o
{
auto& vm = global_object.vm();
Optional<TemporalTime> time_result;
// 1. Let timeResult be ? ToTemporalTimeRecord(fields).
time_result = to_temporal_time_record(global_object, fields);
auto unregulated_time_result = to_temporal_time_record(global_object, fields);
if (vm.exception())
return {};
@ -121,7 +119,7 @@ Optional<ISODateTime> interpret_temporal_date_time_fields(GlobalObject& global_o
return {};
// 4. Let timeResult be ? RegulateTime(timeResult.[[Hour]], timeResult.[[Minute]], timeResult.[[Second]], timeResult.[[Millisecond]], timeResult.[[Microsecond]], timeResult.[[Nanosecond]], overflow).
time_result = regulate_time(global_object, time_result->hour, time_result->minute, time_result->second, time_result->millisecond, time_result->microsecond, time_result->nanosecond, *overflow);
auto time_result = regulate_time(global_object, unregulated_time_result->hour, unregulated_time_result->minute, unregulated_time_result->second, unregulated_time_result->millisecond, unregulated_time_result->microsecond, unregulated_time_result->nanosecond, *overflow);
if (vm.exception())
return {};
@ -130,12 +128,12 @@ Optional<ISODateTime> interpret_temporal_date_time_fields(GlobalObject& global_o
.year = temporal_date->iso_year(),
.month = temporal_date->iso_month(),
.day = temporal_date->iso_day(),
.hour = static_cast<u8>(time_result->hour),
.minute = static_cast<u8>(time_result->minute),
.second = static_cast<u8>(time_result->second),
.millisecond = static_cast<u16>(time_result->millisecond),
.microsecond = static_cast<u16>(time_result->microsecond),
.nanosecond = static_cast<u16>(time_result->nanosecond),
.hour = time_result->hour,
.minute = time_result->minute,
.second = time_result->second,
.millisecond = time_result->millisecond,
.microsecond = time_result->microsecond,
.nanosecond = time_result->nanosecond,
};
}