RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:07:44 +00:00
Code Issues Activity Actions

LibJS: Stop asserting in {Set,Test}IntegrityLevel on missing descriptor

Browse source 
As per the specification (7.3.15 SetIntegrityLevel):
i. Let currentDesc be ? O.[[GetOwnProperty]](k).
ii. If currentDesc is not undefined, then...
This commit is contained in:
Idan Horowitz 2021-06-10 02:34:32 +03:00 • committed by Linus Groh
parent b639bf64f2
commit f63ef4f196
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -209,7 +209,8 @@ bool Object::set_integrity_level(IntegrityLevel level)
property_name = property_index;
}
auto property_descriptor = get_own_property_descriptor(property_name);
VERIFY(property_descriptor.has_value());
if (!property_descriptor.has_value())
continue;
u8 attributes = property_descriptor->is_accessor_descriptor()
? ~Attribute::Configurable
: ~Attribute::Configurable & ~Attribute::Writable;
@ -239,7 +240,8 @@ bool Object::test_integrity_level(IntegrityLevel level)
for (auto& key : keys) {
auto property_name = PropertyName::from_value(global_object(), key);
auto property_descriptor = get_own_property_descriptor(property_name);
VERIFY(property_descriptor.has_value());
if (!property_descriptor.has_value())
continue;
if (property_descriptor->attributes.is_configurable())
return false;
if (level == IntegrityLevel::Frozen && property_descriptor->is_data_descriptor()) {