RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 11:18:13 +00:00
Code Issues Activity Actions

LibEDID: Do not check if ${PNP_IDS_EXPORT_PATH} exists in pnp_ids.cmake

Browse source 
This check isn't needed because download_file() will check if it exists
already before doing the download. Worse, it would prevent the generator
target from being defined if the file existed, which then made CMake not
realize the generated files were important and delete them.
This commit is contained in:
Timothy Flynn 2022-01-25 22:10:48 -05:00 • committed by Andreas Kling
parent e092f1614c
commit f657362fda
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Meta/CMake/pnp_ids.cmake
View file

@ -5,7 +5,7 @@ set(PNP_IDS_URL http://www.uefi.org/uefi-pnp-export)
set(PNP_IDS_EXPORT_PATH ${CMAKE_BINARY_DIR}/pnp_ids.html)
set(PNP_IDS_INSTALL_PATH ${CMAKE_INSTALL_DATAROOTDIR}/${PNP_IDS_FILE})
if(ENABLE_PNP_IDS_DOWNLOAD AND NOT EXISTS ${PNP_IDS_EXPORT_PATH})
if (ENABLE_PNP_IDS_DOWNLOAD)
file(MAKE_DIRECTORY ${CMAKE_INSTALL_DATAROOTDIR})
download_file("${PNP_IDS_URL}" "${PNP_IDS_EXPORT_PATH}")