RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:07:35 +00:00
Code Issues Activity Actions

LibGfx/JPEG: Replace a FIXME with some explanations

Browse source 
Calling the `ycbcr_to_rgb` function still looks unsuitable for this
usage, but it does the job correctly.
This commit is contained in:
Lucas CHOLLET 2023-03-21 19:08:01 -04:00 • committed by Jelle Raaijmakers
parent a9cc61224d
commit f66de973ff
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibGfx/ImageFormats/JPEGLoader.cpp
View file

@ -1306,8 +1306,9 @@ static ErrorOr<void> handle_color_transform(JPEGLoadingContext const& context, V
ycbcr_to_rgb(context, macroblocks); ycbcr_to_rgb(context, macroblocks);
if (context.components.size() == 1) { if (context.components.size() == 1) {
// FIXME: This is what we used to do for grayscale, // With Cb and Cr being equal to zero, this function assign the Y
// we should at least document it and maybe change it. // value (luminosity) to R, G and B. Providing a proper conversion
// from grayscale to RGB.
ycbcr_to_rgb(context, macroblocks); ycbcr_to_rgb(context, macroblocks);
} }