RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:17:45 +00:00
Code Issues Activity Actions

LibWeb: Make DOM Nodes keep their Document alive

Browse source 
In addition to being reference-counted, all nodes that are part of a
document must also keep the document alive.

This is achieved by adding a second ref-count to the Document object
and incrementing/decrementing it whenever a node is created/destroyed
in that document.

This brings us much closer to a proper DOM lifetime model, although
the JS bindings still need more work.
This commit is contained in:
Andreas Kling 2020-10-11 21:52:59 +02:00
parent 99acbbe86b
commit f68ed6d25b
5 changed files with 45 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Libraries/LibWeb/DOM/Document.h
View file

@ -177,9 +177,27 @@ public:
const String& ready_state() const { return m_ready_state; }
void set_ready_state(const String&);
void ref_from_node(Badge<Node>)
{
++m_referencing_node_count;
}
void unref_from_node(Badge<Node>)
{
ASSERT(m_referencing_node_count);
--m_referencing_node_count;
if (!m_referencing_node_count && !ref_count()) {
removed_last_ref();
}
}
void removed_last_ref();
private:
virtual RefPtr<LayoutNode> create_layout_node(const CSS::StyleProperties* parent_style) override;
unsigned m_referencing_node_count { 0 };
OwnPtr<CSS::StyleResolver> m_style_resolver;
RefPtr<CSS::StyleSheetList> m_style_sheets;
RefPtr<Node> m_hovered_node;