RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 10:57:34 +00:00
Code Issues Activity Actions

LibJS: Convert this_bigint_value() to ThrowCompletionOr

Browse source
This commit is contained in:
Linus Groh 2021-10-18 19:44:46 +01:00
parent be28a6142b
commit f6cf44c3db
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/BigIntObject.h
View file

@ -20,7 +20,9 @@ public:
BigIntObject(BigInt&, Object& prototype); BigIntObject(BigInt&, Object& prototype);
virtual ~BigIntObject(); virtual ~BigIntObject();
const BigInt& bigint() const { return m_bigint; } BigInt const& bigint() const { return m_bigint; }
BigInt& bigint() { return m_bigint; }
virtual Value value_of() const override virtual Value value_of() const override
{ {
return Value(&m_bigint); return Value(&m_bigint);

16
Userland/Libraries/LibJS/Runtime/BigIntPrototype.cpp
View file

@ -8,6 +8,7 @@
#include <AK/TypeCasts.h> #include <AK/TypeCasts.h>
#include <LibJS/Runtime/BigIntObject.h> #include <LibJS/Runtime/BigIntObject.h>
#include <LibJS/Runtime/BigIntPrototype.h> #include <LibJS/Runtime/BigIntPrototype.h>
#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/Error.h> #include <LibJS/Runtime/Error.h>
#include <LibJS/Runtime/GlobalObject.h> #include <LibJS/Runtime/GlobalObject.h>
@ -36,23 +37,20 @@ BigIntPrototype::~BigIntPrototype()
} }
// thisBigIntValue ( value ), https://tc39.es/ecma262/#thisbigintvalue // thisBigIntValue ( value ), https://tc39.es/ecma262/#thisbigintvalue
static Value this_bigint_value(GlobalObject& global_object, Value value) static ThrowCompletionOr<BigInt*> this_bigint_value(GlobalObject& global_object, Value value)
{ {
if (value.is_bigint()) if (value.is_bigint())
return value; return &value.as_bigint();
if (value.is_object() && is<BigIntObject>(value.as_object())) if (value.is_object() && is<BigIntObject>(value.as_object()))
return &static_cast<BigIntObject&>(value.as_object()).bigint(); return &static_cast<BigIntObject&>(value.as_object()).bigint();
auto& vm = global_object.vm(); auto& vm = global_object.vm();
vm.throw_exception<TypeError>(global_object, ErrorType::NotAnObjectOfType, "BigInt"); return vm.throw_completion<TypeError>(global_object, ErrorType::NotAnObjectOfType, "BigInt");
return {};
} }
// 21.2.3.3 BigInt.prototype.toString ( [ radix ] ), https://tc39.es/ecma262/#sec-bigint.prototype.tostring // 21.2.3.3 BigInt.prototype.toString ( [ radix ] ), https://tc39.es/ecma262/#sec-bigint.prototype.tostring
JS_DEFINE_NATIVE_FUNCTION(BigIntPrototype::to_string) JS_DEFINE_NATIVE_FUNCTION(BigIntPrototype::to_string)
{ {
auto bigint_value = this_bigint_value(global_object, vm.this_value(global_object)); auto* bigint = TRY_OR_DISCARD(this_bigint_value(global_object, vm.this_value(global_object)));
if (vm.exception())
return {};
double radix = 10; double radix = 10;
if (!vm.argument(0).is_undefined()) { if (!vm.argument(0).is_undefined()) {
radix = TRY_OR_DISCARD(vm.argument(0).to_integer_or_infinity(global_object)); radix = TRY_OR_DISCARD(vm.argument(0).to_integer_or_infinity(global_object));
@ -61,7 +59,7 @@ JS_DEFINE_NATIVE_FUNCTION(BigIntPrototype::to_string)
return {}; return {};
} }
} }
return js_string(vm, bigint_value.as_bigint().big_integer().to_base(radix)); return js_string(vm, bigint->big_integer().to_base(radix));
} }
// 21.2.3.2 BigInt.prototype.toLocaleString ( [ reserved1 [ , reserved2 ] ] ), https://tc39.es/ecma262/#sec-bigint.prototype.tolocalestring // 21.2.3.2 BigInt.prototype.toLocaleString ( [ reserved1 [ , reserved2 ] ] ), https://tc39.es/ecma262/#sec-bigint.prototype.tolocalestring
@ -73,7 +71,7 @@ JS_DEFINE_NATIVE_FUNCTION(BigIntPrototype::to_locale_string)
// 21.2.3.4 BigInt.prototype.valueOf ( ), https://tc39.es/ecma262/#sec-bigint.prototype.valueof // 21.2.3.4 BigInt.prototype.valueOf ( ), https://tc39.es/ecma262/#sec-bigint.prototype.valueof
JS_DEFINE_NATIVE_FUNCTION(BigIntPrototype::value_of) JS_DEFINE_NATIVE_FUNCTION(BigIntPrototype::value_of)
{ {
return this_bigint_value(global_object, vm.this_value(global_object)); return TRY_OR_DISCARD(this_bigint_value(global_object, vm.this_value(global_object)));
} }
} }