RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 06:18:12 +00:00
Code Issues Activity Actions

UserspaceEmulator: Make it possible to wrap PODs in ValueWithShadow

Browse source 
Instead of making it hold the shadow data as another `T`, make it hold
the data as a byte array, and allow it to read the byte array as `T`.
This makes it much easier to make a "read_typed" function in the MMU.
This commit is contained in:
Ali Mohammad Pur 2022-02-27 23:56:46 +03:30 • committed by Andreas Kling
parent e08cf8f554
commit f6e82a8e0a
7 changed files with 115 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/DevTools/UserspaceEmulator/SoftFPU.cpp
View file

@ -300,7 +300,7 @@ void SoftFPU::FSTP_RM80(const X86::Instruction& insn)
f80 = insn.modrm().read128(m_cpu, insn);
*(long double*)value.bytes().data() = fpu_pop();
memcpy(f80.value().bytes().data(), &value, 10); // copy
memset(f80.shadow().bytes().data(), 0x01, 10); // mark as initialized
f80.set_initialized();
insn.modrm().write128(m_cpu, insn, f80);
}
}
@ -688,7 +688,7 @@ void SoftFPU::FDIVR_RM64(const X86::Instruction& insn)
{
if (insn.modrm().is_register()) {
// XXX this is FDIVR, Instruction decodes this weirdly
//fpu_set(insn.modrm().register_index(), fpu_get(0) / fpu_get(insn.modrm().register_index()));
// fpu_set(insn.modrm().register_index(), fpu_get(0) / fpu_get(insn.modrm().register_index()));
fpu_set(insn.modrm().register_index(), fpu_get(insn.modrm().register_index()) / fpu_get(0));
} else {
auto new_f64 = insn.modrm().read64(m_cpu, insn);
@ -1167,13 +1167,13 @@ void SoftFPU::FNSTENV(const X86::Instruction& insn)
* | | TW | 8
* +----------------+---------------+
* | FIP | 12
* +----+-----------+---------------+
* +----+-----------+---------------+
* |0000|fpuOp[10:0]| FIP_sel | 16
* +----+-----------+---------------+
* +----+-----------+---------------+
* | FDP | 20
* +----------------+---------------+
* +----------------+---------------+
* | | FDP_ds | 24
* +----------------|---------------+
* +----------------|---------------+
* */
auto address = insn.modrm().resolve(m_cpu, insn);