RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:47:46 +00:00
Code Issues Activity Actions

CrashReporter+LibCoredump: Show progress window while loading coredump

Browse source 
Some coredumps take a long time to symbolicate, so let's show a simple
window with a progress bar while they are loading.

I'm not super happy with the factoring of this feature, but it's an
absolutely kickass feature that makes crashing feel 100% more responsive
than before, since you now get GUI feedback almost immediately after a
crash occurs. :^)
This commit is contained in:
Andreas Kling 2021-09-21 18:46:10 +02:00
parent 4f224b15ed
commit f6f9599899
3 changed files with 67 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCoredump/Backtrace.h
View file

@ -37,7 +37,7 @@ public:
String to_string(bool color = false) const;
};
Backtrace(const Reader&, const ELF::Core::ThreadInfo&);
Backtrace(const Reader&, const ELF::Core::ThreadInfo&, Function<void(size_t, size_t)> on_progress = {});
~Backtrace();
ELF::Core::ThreadInfo const& thread_info() const { return m_thread_info; }