RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 12:25:06 +00:00
Code Issues Activity Actions

Meta: Properly ignore targets which don't have a component name

Browse source 
Previously we'd add [component_name-NOTFOUND] sections to the
components.ini file for targets which weren't part of a component.
This commit is contained in:
Gunnar Beutner 2022-10-15 11:22:05 +02:00 • committed by Linus Groh
parent acc1c2b3cb
commit f70ec7582f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Meta/CMake/serenity_components.cmake
View file

@ -47,7 +47,7 @@ function(export_components_helper file_name current_dir)
continue() # Custom properties are not allowed to be set on INTERFACE libraries continue() # Custom properties are not allowed to be set on INTERFACE libraries
endif() endif()
get_target_property(component_name "${target}" SERENITY_COMPONENT_NAME) get_target_property(component_name "${target}" SERENITY_COMPONENT_NAME)
if(NOT "${component_name}" STREQUAL "") if(NOT "${component_name}" STREQUAL "" AND NOT "${component_name}" STREQUAL "component_name-NOTFOUND")
get_target_property(component_name "${target}" SERENITY_COMPONENT_NAME) get_target_property(component_name "${target}" SERENITY_COMPONENT_NAME)
get_target_property(component_description "${target}" SERENITY_COMPONENT_DESCRIPTION) get_target_property(component_description "${target}" SERENITY_COMPONENT_DESCRIPTION)
get_target_property(component_recommended "${target}" SERENITY_COMPONENT_RECOMMENDED) get_target_property(component_recommended "${target}" SERENITY_COMPONENT_RECOMMENDED)