From f72f4c5bcad207c6f3436bb6640422e6853f3b68 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 19 Nov 2020 21:53:24 +0100 Subject: [PATCH] LibGUI: Remove AbstractTableView::doubleclick_event() This work is already done (and more correctly) by the parent class (AbstractView) if we just let it take care of the event instead. Fixes the root cause of #4096. --- Libraries/LibGUI/AbstractTableView.cpp | 12 ------------ Libraries/LibGUI/AbstractTableView.h | 1 - 2 files changed, 13 deletions(-) diff --git a/Libraries/LibGUI/AbstractTableView.cpp b/Libraries/LibGUI/AbstractTableView.cpp index 260f168a48..087f217f11 100644 --- a/Libraries/LibGUI/AbstractTableView.cpp +++ b/Libraries/LibGUI/AbstractTableView.cpp @@ -242,18 +242,6 @@ void AbstractTableView::scroll_into_view(const ModelIndex& index, bool scroll_ho ScrollableWidget::scroll_into_view(content_rect(index), scroll_horizontally, scroll_vertically); } -void AbstractTableView::doubleclick_event(MouseEvent& event) -{ - if (!model()) - return; - if (event.button() == MouseButton::Left) { - if (is_editable() && edit_triggers() & EditTrigger::DoubleClicked) - begin_editing(cursor_index()); - else - activate(cursor_index()); - } -} - void AbstractTableView::context_menu_event(ContextMenuEvent& event) { if (!model()) diff --git a/Libraries/LibGUI/AbstractTableView.h b/Libraries/LibGUI/AbstractTableView.h index df0f48c581..dc6698c06a 100644 --- a/Libraries/LibGUI/AbstractTableView.h +++ b/Libraries/LibGUI/AbstractTableView.h @@ -94,7 +94,6 @@ protected: AbstractTableView(); virtual void mousedown_event(MouseEvent&) override; - virtual void doubleclick_event(MouseEvent&) override; virtual void context_menu_event(ContextMenuEvent&) override; virtual void keydown_event(KeyEvent&) override; virtual void resize_event(ResizeEvent&) override;