RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:57:47 +00:00
Code Issues Activity Actions

LibTLS: Prefer structured bindings when iterating over HashMaps

Browse source
This commit is contained in:
Hendiadyoin1 2024-03-01 14:16:25 +01:00 • committed by Andrew Kaster
parent d6c631ebe0
commit f7329f89aa
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibTLS/Certificate.cpp
View file

@ -798,15 +798,15 @@ ErrorOr<Certificate> Certificate::parse_certificate(ReadonlyBytes buffer, bool)
ErrorOr<String> RelativeDistinguishedName::to_string() const ErrorOr<String> RelativeDistinguishedName::to_string() const
{ {
#define ADD_IF_RECOGNIZED(identifier, shorthand_code) \ #define ADD_IF_RECOGNIZED(identifier, shorthand_code) \
if (it->key == identifier) { \ if (member_identifier == identifier) { \
cert_name.appendff("\\{}={}", shorthand_code, it->value); \ cert_name.appendff("\\{}={}", shorthand_code, value); \
continue; \ continue; \
} }
StringBuilder cert_name; StringBuilder cert_name;
for (auto it = m_members.begin(); it != m_members.end(); ++it) { for (auto const& [member_identifier, value] : m_members) {
ADD_IF_RECOGNIZED(enum_value(AttributeType::SerialNumber), "SERIALNUMBER"); ADD_IF_RECOGNIZED(enum_value(AttributeType::SerialNumber), "SERIALNUMBER");
ADD_IF_RECOGNIZED(enum_value(AttributeType::Email), "MAIL"); ADD_IF_RECOGNIZED(enum_value(AttributeType::Email), "MAIL");
ADD_IF_RECOGNIZED(enum_value(AttributeType::Title), "T"); ADD_IF_RECOGNIZED(enum_value(AttributeType::Title), "T");
@ -825,7 +825,7 @@ ErrorOr<String> RelativeDistinguishedName::to_string() const
ADD_IF_RECOGNIZED(enum_value(AttributeType::Dc), "DC"); ADD_IF_RECOGNIZED(enum_value(AttributeType::Dc), "DC");
ADD_IF_RECOGNIZED(enum_value(AttributeType::Uid), "UID"); ADD_IF_RECOGNIZED(enum_value(AttributeType::Uid), "UID");
cert_name.appendff("\\{}={}", it->key, it->value); cert_name.appendff("\\{}={}", member_identifier, value);
} }
#undef ADD_IF_RECOGNIZED #undef ADD_IF_RECOGNIZED