From f742334b93ddc55e425575902d6869452011b7e2 Mon Sep 17 00:00:00 2001
From: Tim Ledbetter <timledbetter@gmail.com>
Date: Wed, 7 Feb 2024 22:25:53 +0000
Subject: [PATCH] HexEditor: Prefer enum class to enum for
 `FindDialog::OptionId`

---
 Userland/Applications/HexEditor/FindDialog.cpp |  8 ++++----
 Userland/Applications/HexEditor/FindDialog.h   | 10 +++++-----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Userland/Applications/HexEditor/FindDialog.cpp b/Userland/Applications/HexEditor/FindDialog.cpp
index 51b04e6930..48895ae6fd 100644
--- a/Userland/Applications/HexEditor/FindDialog.cpp
+++ b/Userland/Applications/HexEditor/FindDialog.cpp
@@ -24,8 +24,8 @@ struct Option {
 
 static constexpr Array<Option, 2> options = {
     {
-        { "ASCII String"sv, OPTION_ASCII_STRING, true, true },
-        { "Hex value"sv, OPTION_HEX_VALUE, true, false },
+        { "ASCII String"sv, OptionId::AsciiString, true, true },
+        { "Hex value"sv, OptionId::HexValue, true, false },
     }
 };
 
@@ -77,9 +77,9 @@ ErrorOr<ByteBuffer> FindDialog::process_input(StringView text_value, OptionId op
     VERIFY(!text_value.is_empty());
 
     switch (opt) {
-    case OPTION_ASCII_STRING:
+    case OptionId::AsciiString:
         return ByteBuffer::copy(text_value.bytes());
-    case OPTION_HEX_VALUE: {
+    case OptionId::HexValue: {
         auto text_no_spaces = text_value.replace(" "sv, ""sv, ReplaceMode::All);
         return decode_hex(text_no_spaces);
     }
diff --git a/Userland/Applications/HexEditor/FindDialog.h b/Userland/Applications/HexEditor/FindDialog.h
index 122630e2f2..528d4b0754 100644
--- a/Userland/Applications/HexEditor/FindDialog.h
+++ b/Userland/Applications/HexEditor/FindDialog.h
@@ -11,10 +11,10 @@
 #include <AK/String.h>
 #include <LibGUI/Dialog.h>
 
-enum OptionId {
-    OPTION_INVALID = -1,
-    OPTION_ASCII_STRING,
-    OPTION_HEX_VALUE
+enum class OptionId {
+    Invalid = -1,
+    AsciiString,
+    HexValue
 };
 
 class FindDialog : public GUI::Dialog {
@@ -41,5 +41,5 @@ private:
 
     bool m_find_all { false };
     String m_text_value;
-    OptionId m_selected_option { OPTION_INVALID };
+    OptionId m_selected_option { OptionId::Invalid };
 };