RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:38:11 +00:00
Code Issues Activity Actions

LibELF: Avoid calculating symbol hashes when we don't need them

Browse source
This commit is contained in:
Gunnar Beutner 2021-04-22 09:16:17 +02:00 • committed by Andreas Kling
parent 39d34fb1f1
commit f74b8a2d1f
4 changed files with 44 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibELF/DynamicLinker.cpp
View file

@ -45,15 +45,14 @@ bool g_allowed_to_check_environment_variables { false };
bool g_do_breakpoint_trap_before_entry { false };
}
Optional<DynamicObject::SymbolLookupResult> DynamicLinker::lookup_global_symbol(const StringView& symbol)
Optional<DynamicObject::SymbolLookupResult> DynamicLinker::lookup_global_symbol(const StringView& name)
{
Optional<DynamicObject::SymbolLookupResult> weak_result;
auto gnu_hash = compute_gnu_hash(symbol);
auto sysv_hash = compute_sysv_hash(symbol);
auto symbol = DynamicObject::HashSymbol { name };
for (auto& lib : g_global_objects) {
auto res = lib->lookup_symbol(symbol, gnu_hash, sysv_hash);
auto res = lib->lookup_symbol(symbol);
if (!res.has_value())
continue;
if (res.value().bind == STB_GLOBAL)