RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:07:35 +00:00
Code Issues Activity Actions

LibELF: Avoid calculating symbol hashes when we don't need them

Browse source
This commit is contained in:
Gunnar Beutner 2021-04-22 09:16:17 +02:00 • committed by Andreas Kling
parent 39d34fb1f1
commit f74b8a2d1f
4 changed files with 44 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Userland/Libraries/LibELF/DynamicObject.h
View file

@ -162,6 +162,23 @@ public:
GNU
};
class HashSymbol {
public:
HashSymbol(const StringView& name)
: m_name(name)
{
}
StringView name() const { return m_name; }
u32 gnu_hash() const;
u32 sysv_hash() const;
private:
StringView m_name;
mutable Optional<u32> m_gnu_hash;
mutable Optional<u32> m_sysv_hash;
};
class HashSection : public Section {
public:
HashSection(const Section& section, HashType hash_type)
@ -170,11 +187,11 @@ public:
{
}
Optional<Symbol> lookup_symbol(const StringView& name, u32 gnu_hash, u32 sysv_hash) const
Optional<Symbol> lookup_symbol(const HashSymbol& symbol) const
{
if (m_hash_type == HashType::SYSV)
return lookup_sysv_symbol(name, sysv_hash);
return lookup_gnu_symbol(name, gnu_hash);
return lookup_sysv_symbol(symbol.name(), symbol.sysv_hash());
return lookup_gnu_symbol(symbol.name(), symbol.gnu_hash());
}
private:
@ -253,7 +270,7 @@ public:
};
Optional<SymbolLookupResult> lookup_symbol(const StringView& name) const;
Optional<SymbolLookupResult> lookup_symbol(const StringView& name, u32 gnu_hash, u32 sysv_hash) const;
Optional<SymbolLookupResult> lookup_symbol(const HashSymbol& symbol) const;
// Will be called from _fixup_plt_entry, as part of the PLT trampoline
VirtualAddress patch_plt_entry(u32 relocation_offset);