RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:07:43 +00:00
Code Issues Activity Actions

LibWeb: Always use quirks mode when parsing SVG width/height attributes

Browse source 
This is a bit if a hack, but without this unitless values for these
attributes fail to parse with <!DOCTYPE html>.
This commit is contained in:
MacDue 2023-04-10 12:36:34 +01:00 • committed by Andreas Kling
parent 809c15d1ee
commit f753a4f640
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/SVG/SVGSVGElement.cpp
View file

@ -37,6 +37,13 @@ JS::GCPtr<Layout::Node> SVGSVGElement::create_layout_node(NonnullRefPtr<CSS::Sty
void SVGSVGElement::apply_presentational_hints(CSS::StyleProperties& style) const
{
// NOTE: Hack to ensure SVG unitless widths/heights are parsed even with <!DOCTYPE html>
auto previous_quirks_mode = document().mode();
const_cast<DOM::Document&>(document()).set_quirks_mode(DOM::QuirksMode::Yes);
ScopeGuard reset_quirks_mode = [&] {
const_cast<DOM::Document&>(document()).set_quirks_mode(previous_quirks_mode);
};
auto width_attribute = attribute(SVG::AttributeNames::width);
auto parsing_context = CSS::Parser::ParsingContext { document() };
if (auto width_value = parse_css_value(parsing_context, attribute(Web::HTML::AttributeNames::width), CSS::PropertyID::Width)) {