mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 04:37:34 +00:00
LibJS: Add MarkedValueList and use it for argument passing
A MarkedValueList is basically a Vector<JS::Value> that registers with the Heap and makes sure that the stored values don't get GC'd. Before this change, we were unsafely keeping Vector<JS::Value> in some places, which is out-of-reach for the live reference finding logic since Vector puts its elements on the heap by default. We now pass all the JavaScript tests even when running with "js -g", which does a GC on every heap allocation.
This commit is contained in:
parent
cb3cf589ed
commit
f7a1696087
13 changed files with 178 additions and 16 deletions
|
@ -68,6 +68,9 @@ public:
|
|||
void did_create_handle(Badge<HandleImpl>, HandleImpl&);
|
||||
void did_destroy_handle(Badge<HandleImpl>, HandleImpl&);
|
||||
|
||||
void did_create_marked_value_list(Badge<MarkedValueList>, MarkedValueList&);
|
||||
void did_destroy_marked_value_list(Badge<MarkedValueList>, MarkedValueList&);
|
||||
|
||||
void defer_gc(Badge<DeferGC>);
|
||||
void undefer_gc(Badge<DeferGC>);
|
||||
|
||||
|
@ -90,6 +93,8 @@ private:
|
|||
Vector<NonnullOwnPtr<HeapBlock>> m_blocks;
|
||||
HashTable<HandleImpl*> m_handles;
|
||||
|
||||
HashTable<MarkedValueList*> m_marked_value_lists;
|
||||
|
||||
size_t m_gc_deferrals { 0 };
|
||||
bool m_should_gc_when_deferral_ends { false };
|
||||
};
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue