RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 08:17:34 +00:00
Code Issues Activity Actions

LibWeb: Don't assume name is string in HTMLCollectionWrapper::get()

Browse source 
If the property name is not a string (symbol or integer), we should
just defer to the base class instead of trying to handle it.

Fixes #6575.
This commit is contained in:
Andreas Kling 2021-04-23 15:45:54 +02:00
parent 6efcc2fc99
commit f7a33043e0
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Bindings/HTMLCollectionWrapperCustom.cpp
View file

@ -14,6 +14,8 @@ namespace Web::Bindings {
JS::Value HTMLCollectionWrapper::get(JS::PropertyName const& name, JS::Value receiver, bool without_side_effects) const JS::Value HTMLCollectionWrapper::get(JS::PropertyName const& name, JS::Value receiver, bool without_side_effects) const
{ {
if (!name.is_string())
return Base::get(name, receiver, without_side_effects);
auto* item = const_cast<DOM::HTMLCollection&>(impl()).named_item(name.to_string()); auto* item = const_cast<DOM::HTMLCollection&>(impl()).named_item(name.to_string());
if (!item) if (!item)
return Base::get(name, receiver, without_side_effects); return Base::get(name, receiver, without_side_effects);