RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 22:38:12 +00:00
Code Issues Activity Actions

LibHTML: Move layout tree building to a LayoutTreeBuilder class

Browse source 
Building a whole layout tree shouldn't be a concern of Node, so this
patch moves it to a separate class.
This commit is contained in:
Andreas Kling 2019-10-15 12:22:41 +02:00
parent d14b60533f
commit f7cd5662ef
6 changed files with 70 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

51
Libraries/LibHTML/Layout/LayoutTreeBuilder.cpp Normal file
View file

@ -0,0 +1,51 @@
#include <LibHTML/DOM/Document.h>
#include <LibHTML/DOM/ParentNode.h>
#include <LibHTML/Layout/LayoutNode.h>
#include <LibHTML/Layout/LayoutText.h>
#include <LibHTML/Layout/LayoutTreeBuilder.h>
LayoutTreeBuilder::LayoutTreeBuilder()
{
}
static RefPtr<LayoutNode> create_layout_tree(Node& node, const StyleProperties* parent_style)
{
auto layout_node = node.create_layout_node(node.document().style_resolver(), parent_style);
if (!layout_node)
return nullptr;
if (!node.has_children())
return layout_node;
NonnullRefPtrVector<LayoutNode> layout_children;
bool have_inline_children = false;
bool have_block_children = false;
to<ParentNode>(node).for_each_child([&](Node& child) {
auto layout_child = create_layout_tree(child, &layout_node->style());
if (!layout_child)
return;
if (layout_child->is_inline())
have_inline_children = true;
if (layout_child->is_block())
have_block_children = true;
layout_children.append(layout_child.release_nonnull());
});
for (auto& layout_child : layout_children)
if (have_block_children && have_inline_children && !layout_child.is_block()) {
if (is<LayoutText>(layout_child) && to<LayoutText>(layout_child).text_for_style(*parent_style) == " ")
continue;
layout_node->inline_wrapper().append_child(layout_child);
} else {
layout_node->append_child(layout_child);
}
return layout_node;
}
RefPtr<LayoutNode> LayoutTreeBuilder::build(Node& node)
{
// FIXME: Support building partial trees.
ASSERT(is<Document>(node));
return create_layout_tree(node, nullptr);
}