RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:47:37 +00:00
Code Issues Activity Actions

LibJS: Set declared for-in and for-of variables as first time.

Browse source 
These declarations might be const, and now when we're handling it
properly, we have to set values to them correctly.
This commit is contained in:
speles 2021-02-26 00:37:27 +02:00 • committed by Andreas Kling
parent 913fd8de13
commit f7d64e9fa8
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/AST.cpp
View file

@ -476,7 +476,8 @@ Value ForInStatement::execute(Interpreter& interpreter, GlobalObject& global_obj
interpreter.enter_node(*this);
ScopeGuard exit_node { [&] { interpreter.exit_node(*this); } };
if (!is<VariableDeclaration>(*m_lhs) && !is<Identifier>(*m_lhs)) {
bool has_declaration = is<VariableDeclaration>(*m_lhs);
if (!has_declaration && !is<Identifier>(*m_lhs)) {
// FIXME: Implement "for (foo.bar in baz)", "for (foo[0] in bar)"
VERIFY_NOT_REACHED();
}
@ -494,7 +495,7 @@ Value ForInStatement::execute(Interpreter& interpreter, GlobalObject& global_obj
while (object) {
auto property_names = object->get_own_properties(*object, Object::PropertyKind::Key, true);
for (auto& property_name : property_names.as_object().indexed_properties()) {
interpreter.vm().set_variable(variable_name, property_name.value_and_attributes(object).value, global_object);
interpreter.vm().set_variable(variable_name, property_name.value_and_attributes(object).value, global_object, has_declaration);
if (interpreter.exception())
return {};
last_value = interpreter.execute_statement(global_object, *m_body);
@ -523,7 +524,8 @@ Value ForOfStatement::execute(Interpreter& interpreter, GlobalObject& global_obj
interpreter.enter_node(*this);
ScopeGuard exit_node { [&] { interpreter.exit_node(*this); } };
if (!is<VariableDeclaration>(*m_lhs) && !is<Identifier>(*m_lhs)) {
bool has_declaration = is<VariableDeclaration>(*m_lhs);
if (!has_declaration && !is<Identifier>(*m_lhs)) {
// FIXME: Implement "for (foo.bar of baz)", "for (foo[0] of bar)"
VERIFY_NOT_REACHED();
}
@ -539,7 +541,7 @@ Value ForOfStatement::execute(Interpreter& interpreter, GlobalObject& global_obj
return {};
get_iterator_values(global_object, rhs_result, [&](Value value) {
interpreter.vm().set_variable(variable_name, value, global_object);
interpreter.vm().set_variable(variable_name, value, global_object, has_declaration);
last_value = interpreter.execute_statement(global_object, *m_body);
if (interpreter.exception())
return IterationDecision::Break;