From f802920a3aab0d553470176f11d13c42be3c5016 Mon Sep 17 00:00:00 2001 From: Karol Kosek Date: Sun, 12 Feb 2023 10:37:38 +0100 Subject: [PATCH] Userland: Use default initializer instead of an empty string for Buttons --- Userland/Applications/Piano/ProcessorParameterWidget/Toggle.h | 3 +-- Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp | 2 +- Userland/Games/Chess/PromotionDialog.cpp | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Userland/Applications/Piano/ProcessorParameterWidget/Toggle.h b/Userland/Applications/Piano/ProcessorParameterWidget/Toggle.h index 0ca2eaa5f4..041a565f43 100644 --- a/Userland/Applications/Piano/ProcessorParameterWidget/Toggle.h +++ b/Userland/Applications/Piano/ProcessorParameterWidget/Toggle.h @@ -16,8 +16,7 @@ class ProcessorParameterToggle : public GUI::CheckBox { public: ProcessorParameterToggle(DSP::ProcessorBooleanParameter& parameter) - : CheckBox("") - , m_parameter(parameter) + : m_parameter(parameter) { on_checked = [this](auto checked) { if (m_currently_setting_from_ui) diff --git a/Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp b/Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp index d9800ee320..d297186662 100644 --- a/Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp +++ b/Userland/Applications/Spreadsheet/SpreadsheetWidget.cpp @@ -44,7 +44,7 @@ SpreadsheetWidget::SpreadsheetWidget(GUI::Window& parent_window, NonnullRefPtrVe auto& current_cell_label = top_bar.add(""); current_cell_label.set_fixed_width(50); - auto& help_button = top_bar.add(""); + auto& help_button = top_bar.add(); help_button.set_icon(Gfx::Bitmap::load_from_file("/res/icons/16x16/app-help.png"sv).release_value_but_fixme_should_propagate_errors()); help_button.set_tooltip("Functions Help"); help_button.set_fixed_size(20, 20); diff --git a/Userland/Games/Chess/PromotionDialog.cpp b/Userland/Games/Chess/PromotionDialog.cpp index 06e742ae24..58121312d1 100644 --- a/Userland/Games/Chess/PromotionDialog.cpp +++ b/Userland/Games/Chess/PromotionDialog.cpp @@ -23,7 +23,7 @@ PromotionDialog::PromotionDialog(ChessWidget& chess_widget) main_widget->set_layout(); for (auto const& type : { Chess::Type::Queen, Chess::Type::Knight, Chess::Type::Rook, Chess::Type::Bishop }) { - auto& button = main_widget->add(""); + auto& button = main_widget->add(); button.set_fixed_height(70); button.set_icon(chess_widget.get_piece_graphic({ chess_widget.board().turn(), type })); button.on_click = [this, type](auto) {