RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:37:35 +00:00
Code Issues Activity Actions

LibC: Deprecate strcpy(), strncpy(), strcat() and strncat() :^)

Browse source 
And also mark strlcpy() and strlcat() with __attribute__((warn_unused_result)).

Since our code is warning-free, this ensures we never misuse those functions.
(Or are very sure about doing it when turning off the warning for a particular
piece of code.)
This commit is contained in:
Sergey Bugaev 2020-08-25 17:48:52 +03:00 • committed by Andreas Kling
parent 0106647ab8
commit f808810d00
3 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibC/termcap.cpp
View file

@ -95,6 +95,11 @@ static void ensure_caps()
caps->set("li", "25");
}
// Unfortunately, tgetstr() doesn't accept a size argument for the buffer
// pointed to by area, so we have to use bare strcpy().
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
char* tgetstr(const char* id, char** area)
{
ensure_caps();
@ -113,6 +118,8 @@ char* tgetstr(const char* id, char** area)
return nullptr;
}
#pragma GCC diagnostic pop
int tgetflag(const char* id)
{
(void)id;