RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:57:34 +00:00
Code Issues Activity Actions

Everywhere: Use nothrow new with adopt_{ref,own}_if_nonnull

Browse source 
This commit converts naked `new`s to `AK::try_make` and `AK::try_create`
wherever possible. If the called constructor is private, this can not be
done, so we instead now use the standard-defined and compiler-agnostic
`new (nothrow)`.
This commit is contained in:
Daniel Bertalan 2021-06-20 10:21:16 +02:00 • committed by Ali Mohammad Pur
parent 00915e8948
commit f820917a76
45 changed files with 64 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/AK/TestRefPtr.cpp
View file

@ -150,7 +150,7 @@ TEST_CASE(self_observers)
TEST_CASE(adopt_ref_if_nonnull)
{
RefPtr<SelfAwareObject> object = adopt_ref_if_nonnull(new SelfAwareObject);
RefPtr<SelfAwareObject> object = adopt_ref_if_nonnull(new (nothrow) SelfAwareObject);
EXPECT_EQ(object.is_null(), false);
EXPECT_EQ(object->ref_count(), 1u);

2
Tests/AK/TestVariant.cpp
View file

@ -160,7 +160,7 @@ TEST_CASE(return_values)
TEST_CASE(return_values_by_reference)
{
auto ref = adopt_ref_if_nonnull(new Object());
auto ref = adopt_ref_if_nonnull(new (nothrow) Object());
Variant<int, String, float> the_value { 42.0f };
auto& value = the_value.visit(