From f840fb6b4e1590d2d539be4a6d0d2de97c436b0f Mon Sep 17 00:00:00 2001
From: Nico Weber <thakis@chromium.org>
Date: Tue, 30 Jan 2024 20:59:50 -0500
Subject: [PATCH] LibPDF: Make DeviceCMYKColorSpace::the() fallible

No behavior change.
---
 Userland/Libraries/LibPDF/ColorSpace.cpp | 4 ++--
 Userland/Libraries/LibPDF/ColorSpace.h   | 2 +-
 Userland/Libraries/LibPDF/Renderer.cpp   | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Userland/Libraries/LibPDF/ColorSpace.cpp b/Userland/Libraries/LibPDF/ColorSpace.cpp
index 7e89ff3c09..b0dc5598d5 100644
--- a/Userland/Libraries/LibPDF/ColorSpace.cpp
+++ b/Userland/Libraries/LibPDF/ColorSpace.cpp
@@ -53,7 +53,7 @@ PDFErrorOr<NonnullRefPtr<ColorSpace>> ColorSpace::create(DeprecatedFlyString con
     if (name == CommonNames::DeviceRGB)
         return DeviceRGBColorSpace::the();
     if (name == CommonNames::DeviceCMYK)
-        return DeviceCMYKColorSpace::the();
+        return TRY(DeviceCMYKColorSpace::the());
     if (name == CommonNames::Pattern)
         return Error::rendering_unsupported_error("Pattern color spaces not yet implemented");
     VERIFY_NOT_REACHED();
@@ -134,7 +134,7 @@ Vector<float> DeviceRGBColorSpace::default_decode() const
     return { 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f };
 }
 
-NonnullRefPtr<DeviceCMYKColorSpace> DeviceCMYKColorSpace::the()
+ErrorOr<NonnullRefPtr<DeviceCMYKColorSpace>> DeviceCMYKColorSpace::the()
 {
     static auto instance = adopt_ref(*new DeviceCMYKColorSpace());
     return instance;
diff --git a/Userland/Libraries/LibPDF/ColorSpace.h b/Userland/Libraries/LibPDF/ColorSpace.h
index c3f9329d53..4b549ec6fe 100644
--- a/Userland/Libraries/LibPDF/ColorSpace.h
+++ b/Userland/Libraries/LibPDF/ColorSpace.h
@@ -112,7 +112,7 @@ private:
 
 class DeviceCMYKColorSpace final : public ColorSpace {
 public:
-    static NonnullRefPtr<DeviceCMYKColorSpace> the();
+    static ErrorOr<NonnullRefPtr<DeviceCMYKColorSpace>> the();
 
     ~DeviceCMYKColorSpace() override = default;
 
diff --git a/Userland/Libraries/LibPDF/Renderer.cpp b/Userland/Libraries/LibPDF/Renderer.cpp
index 8830143de2..e6ff7dfebc 100644
--- a/Userland/Libraries/LibPDF/Renderer.cpp
+++ b/Userland/Libraries/LibPDF/Renderer.cpp
@@ -695,14 +695,14 @@ RENDERER_HANDLER(set_painting_color_and_space_to_rgb)
 
 RENDERER_HANDLER(set_stroking_color_and_space_to_cmyk)
 {
-    state().stroke_color_space = DeviceCMYKColorSpace::the();
+    state().stroke_color_space = TRY(DeviceCMYKColorSpace::the());
     state().stroke_style = TRY(state().stroke_color_space->style(args));
     return {};
 }
 
 RENDERER_HANDLER(set_painting_color_and_space_to_cmyk)
 {
-    state().paint_color_space = DeviceCMYKColorSpace::the();
+    state().paint_color_space = TRY(DeviceCMYKColorSpace::the());
     state().paint_style = TRY(state().paint_color_space->style(args));
     return {};
 }