RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:48:12 +00:00
Code Issues Activity Actions

LibSoftGPU: Clamp to edge instead of border

Browse source 
According to the Khronos FAQ on texture edge sampling, the `GL_CLAMP`
option was never implemented in hardware and as such, it was
deprecated. A lot of applications and games depend on `GL_CLAMP` not
really meaning `GL_CLAMP` but `GL_CLAMP_TO_EDGE`, so we introduce an
option to toggle this behavior at compile-time.
This commit is contained in:
Jelle Raaijmakers 2021-12-26 23:38:51 +01:00 • committed by Andreas Kling
parent d9ea1fe4c9
commit f856f49edb
1 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibSoftGPU/Sampler.cpp
View file

@ -10,12 +10,16 @@
namespace SoftGPU {
constexpr static float fracf(float value)
// See: https://www.khronos.org/opengl/wiki/Common_Mistakes#Texture_edge_color_problem
// FIXME: make this dynamically configurable through ConfigServer
static constexpr bool CLAMP_DEPRECATED_BEHAVIOR = false;
static constexpr float fracf(float value)
{
return value - floorf(value);
}
constexpr static float wrap_repeat(float value)
static constexpr float wrap_repeat(float value)
{
return fracf(value);
}
@ -39,7 +43,7 @@ static constexpr float wrap_mirrored_repeat(float value, unsigned num_texels)
return wrap_clamp_to_edge(iseven ? frac : 1 - frac, num_texels);
}
constexpr static float wrap(float value, TextureWrapMode mode, unsigned num_texels)
static constexpr float wrap(float value, TextureWrapMode mode, unsigned num_texels)
{
switch (mode) {
case TextureWrapMode::Repeat:
@ -47,7 +51,10 @@ constexpr static float wrap(float value, TextureWrapMode mode, unsigned num_texe
case TextureWrapMode::MirroredRepeat:
return wrap_mirrored_repeat(value, num_texels);
case TextureWrapMode::Clamp:
return wrap_clamp(value);
if constexpr (CLAMP_DEPRECATED_BEHAVIOR) {
return wrap_clamp(value);
}
return wrap_clamp_to_edge(value, num_texels);
case TextureWrapMode::ClampToBorder:
case TextureWrapMode::ClampToEdge:
return wrap_clamp_to_edge(value, num_texels);