RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:57:46 +00:00
Code Issues Activity Actions

LibJS: Object.getOwnPropertyNames() should enumerate String's .length

Browse source 
We were incorrectly aborting property name enumeration after generating
names for all the indexable properties in the underlying string.
This commit is contained in:
Andreas Kling 2021-06-19 11:46:08 +02:00
parent 686213c2b8
commit f86e241699
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -299,8 +299,6 @@ MarkedValueList Object::get_own_properties(PropertyKind kind, bool only_enumerab
if (vm().exception())
return MarkedValueList { heap() };
}
return properties;
}
if (return_type != GetOwnPropertyReturnType::SymbolOnly) {

5
Userland/Libraries/LibJS/Tests/builtins/Object/Object.getOwnPropertyNames.js
View file

@ -12,3 +12,8 @@ test("use with object with symbol keys", () => {
let names = Object.getOwnPropertyNames({ foo: 1, [Symbol("bar")]: 2, baz: 3 });
expect(names).toEqual(["foo", "baz"]);
});
test("use with String object", () => {
let names = Object.getOwnPropertyNames(new String("foo"));
expect(names).toEqual(["0", "1", "2", "length"]);
});