RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:57:34 +00:00
Code Issues Activity Actions

Kernel: Harden DevPtsFSInode::traverse_as_directory against OOM

Browse source 
Use the try variants of AK::StringBuilder append APIs to harden this
function against OOM.
This commit is contained in:
Brian Gianforcaro 2022-01-09 02:59:20 -08:00 • committed by Andreas Kling
parent 787bfcc530
commit f8ad3cc6a0
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/FileSystem/DevPtsFS.cpp
View file

@ -114,9 +114,10 @@ ErrorOr<void> DevPtsFSInode::traverse_as_directory(Function<ErrorOr<void>(FileSy
TRY(callback({ "..", identifier(), 0 })); TRY(callback({ "..", identifier(), 0 }));
return SlavePTY::all_instances().with([&](auto& list) -> ErrorOr<void> { return SlavePTY::all_instances().with([&](auto& list) -> ErrorOr<void> {
StringBuilder builder;
for (SlavePTY& slave_pty : list) { for (SlavePTY& slave_pty : list) {
StringBuilder builder; builder.clear();
builder.appendff("{}", slave_pty.index()); TRY(builder.try_appendff("{}", slave_pty.index()));
TRY(callback({ builder.string_view(), { fsid(), pty_index_to_inode_index(slave_pty.index()) }, 0 })); TRY(callback({ builder.string_view(), { fsid(), pty_index_to_inode_index(slave_pty.index()) }, 0 }));
} }
return {}; return {};