RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 23:57:43 +00:00
Code Issues Activity Actions

LibJS: Disallow NumericLiteral immediately followed by Identifier

Browse source 
From the spec: https://tc39.es/ecma262/#sec-literals-numeric-literals

The SourceCharacter immediately following a NumericLiteral must not be
an IdentifierStart or DecimalDigit.

For example: 3in is an error and not the two input elements 3 and in.
This commit is contained in:
Linus Groh 2020-10-22 22:18:31 +01:00 • committed by Andreas Kling
parent 80bb22788f
commit f8ae6fa713
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Parser.cpp
View file

@ -1827,6 +1827,8 @@ Token Parser::consume_and_validate_numeric_literal()
auto token = consume(TokenType::NumericLiteral); auto token = consume(TokenType::NumericLiteral);
if (m_parser_state.m_strict_mode && is_unprefixed_octal_number(token.value())) if (m_parser_state.m_strict_mode && is_unprefixed_octal_number(token.value()))
syntax_error("Unprefixed octal number not allowed in strict mode", literal_start_line, literal_start_column); syntax_error("Unprefixed octal number not allowed in strict mode", literal_start_line, literal_start_column);
if (match_identifier_name() && m_parser_state.m_current_token.trivia().is_empty())
syntax_error("Numeric literal must not be immediately followed by identifier");
return token; return token;
} }

2
Libraries/LibJS/Tests/numeric-literals-basic.js
View file

@ -46,4 +46,6 @@ test("invalid numeric literals", () => {
expect("0b").not.toEval(); expect("0b").not.toEval();
expect("0o").not.toEval(); expect("0o").not.toEval();
expect("'use strict'; 0755").not.toEval(); expect("'use strict'; 0755").not.toEval();
expect("1in[]").not.toEval();
expect("2instanceof foo").not.toEval();
}); });