RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-17 11:17:36 +00:00
Code Issues Activity Actions

Kernel/Storage+Base: Fix boot_device_addressing document for NVMe

Browse source 
The LUN.target_id parameter points to a NVMe Namespace which starts from
1 and not 0. Fix the document to reflect the same while addressing a
nvme device in the boot parameters
This commit is contained in:
Pankaj Raghav 2023-03-11 10:44:18 +01:00 • committed by Linus Groh
parent 84e17fcbcc
commit f8b67e1596
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Base/usr/share/man/man7/boot_device_addressing.md
View file

@ -30,7 +30,7 @@ to address raw `StorageDevice`s:
``` ```
ata0:0:0 [First ATA controller, ATA first primary channel, master device] ata0:0:0 [First ATA controller, ATA first primary channel, master device]
nvme0:0 [First NVMe Controller, First NVMe Namespace] nvme0:1:0 [First NVMe Controller, First NVMe Namespace, Not Applicable]
ramdisk0 [First Ramdisk] ramdisk0 [First Ramdisk]
``` ```

2
Kernel/Storage/StorageDevice.h
View file

@ -46,7 +46,7 @@ public:
// For example, on a legacy ATA instance, one might connect an harddrive to the second IDE controller, // For example, on a legacy ATA instance, one might connect an harddrive to the second IDE controller,
// to the Primary channel as a slave device, which translates to LUN 1:0:1. // to the Primary channel as a slave device, which translates to LUN 1:0:1.
// On NVMe, for example, connecting a second PCIe NVMe storage device as a sole NVMe namespace translates // On NVMe, for example, connecting a second PCIe NVMe storage device as a sole NVMe namespace translates
// to LUN 1:0:0. // to LUN 1:1:0.
struct LUNAddress { struct LUNAddress {
u32 controller_id; u32 controller_id;
u32 target_id; u32 target_id;