From f8d6d61da5fd5b074cb154c0dee6c7cbf3674c61 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 7 Apr 2020 10:26:54 +0200 Subject: [PATCH] LibWeb: Fix null dereference in HtmlView::mousedown_event Running event handlers in response to a mouse event may cause full layout invalidation, so we can't expect the layout root to be present right after returning from JS. Fixes #1629. --- Libraries/LibWeb/HtmlView.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/HtmlView.cpp b/Libraries/LibWeb/HtmlView.cpp index 496de706c3..60c177c569 100644 --- a/Libraries/LibWeb/HtmlView.cpp +++ b/Libraries/LibWeb/HtmlView.cpp @@ -242,7 +242,8 @@ void HtmlView::mousedown_event(GUI::MouseEvent& event) } } else { if (event.button() == GUI::MouseButton::Left) { - layout_root()->selection().set({ result.layout_node, result.index_in_node }, {}); + if (layout_root()) + layout_root()->selection().set({ result.layout_node, result.index_in_node }, {}); dump_selection("MouseDown"); m_in_mouse_selection = true; }