RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:38:11 +00:00
Code Issues Activity Actions

Userland: Resolve unused-but-set-varaible warnings

Browse source 
These are almost always bugs, so enable globally.

Remove unused counter variables in SystemMonitor and disk_benchmark.
This commit is contained in:
Andrew Kaster 2022-01-03 02:52:02 -07:00 • committed by Brian Gianforcaro
parent d809637023
commit f8ea9cd64e
3 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Applications/SystemMonitor/ProcessModel.cpp
View file

@ -334,7 +334,6 @@ void ProcessModel::update()
auto all_processes = Core::ProcessStatisticsReader::get_all(m_proc_all);
HashTable<int> live_tids;
u64 sum_time_scheduled = 0, sum_time_scheduled_kernel = 0;
u64 total_time_scheduled_diff = 0;
if (all_processes.has_value()) {
if (m_has_total_scheduled_time)
@ -382,8 +381,6 @@ void ProcessModel::update()
state.cpu_percent = 0;
state.priority = thread.priority;
state.state = thread.state;
sum_time_scheduled += thread.time_user + thread.time_kernel;
sum_time_scheduled_kernel += thread.time_kernel;
auto& thread_data = *m_threads.ensure(thread.tid, [] { return make<Thread>(); });
thread_data.previous_state = move(thread_data.current_state);
thread_data.current_state = move(state);