From f8f35fdaad4030178f8cc38c5d6efb7dc166a36a Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Fri, 14 Apr 2023 07:30:44 -0400 Subject: [PATCH] LibVideo: Remove hook to notify clients upon reaching end of the stream This reverts commit 33047b38ec0d9ce55bea2f74c00972711e106a30. This use case is now satisfied with on_playback_state_change and getting the playback state from the PlaybackManager. --- Userland/Libraries/LibVideo/PlaybackManager.cpp | 4 ---- Userland/Libraries/LibVideo/PlaybackManager.h | 1 - 2 files changed, 5 deletions(-) diff --git a/Userland/Libraries/LibVideo/PlaybackManager.cpp b/Userland/Libraries/LibVideo/PlaybackManager.cpp index 8482b7acd3..349af219f9 100644 --- a/Userland/Libraries/LibVideo/PlaybackManager.cpp +++ b/Userland/Libraries/LibVideo/PlaybackManager.cpp @@ -129,10 +129,6 @@ void PlaybackManager::dispatch_decoder_error(DecoderError error) case DecoderErrorCategory::EndOfStream: dbgln_if(PLAYBACK_MANAGER_DEBUG, "{}", error.string_literal()); TRY_OR_FATAL_ERROR(m_playback_handler->stop()); - - if (on_end_of_stream) - on_end_of_stream(); - break; default: dbgln("Playback error encountered: {}", error.string_literal()); diff --git a/Userland/Libraries/LibVideo/PlaybackManager.h b/Userland/Libraries/LibVideo/PlaybackManager.h index 6445f72236..49390319a1 100644 --- a/Userland/Libraries/LibVideo/PlaybackManager.h +++ b/Userland/Libraries/LibVideo/PlaybackManager.h @@ -135,7 +135,6 @@ public: Function)> on_video_frame; Function on_playback_state_change; - Function on_end_of_stream; Function on_decoder_error; Function on_fatal_playback_error;