RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:37:35 +00:00
Code Issues Activity Actions

LibWeb: Remove redundant identifier_to_edge() function

Browse source 
The enums generator has this covered already.
This commit is contained in:
Sam Atkins 2023-11-02 16:02:12 +00:00 • committed by Sam Atkins
parent aef654592f
commit f918785698
1 changed files with 3 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -2871,22 +2871,6 @@ RefPtr<StyleValue> Parser::parse_background_value(Vector<ComponentValue> const&
background_clip.release_nonnull()); background_clip.release_nonnull());
} }
static Optional<PositionEdge> identifier_to_edge(ValueID identifier)
{
switch (identifier) {
case ValueID::Top:
return PositionEdge::Top;
case ValueID::Bottom:
return PositionEdge::Bottom;
case ValueID::Left:
return PositionEdge::Left;
case ValueID::Right:
return PositionEdge::Right;
default:
return {};
}
}
static Optional<LengthPercentage> style_value_to_length_percentage(auto value) static Optional<LengthPercentage> style_value_to_length_percentage(auto value)
{ {
if (value->is_percentage()) if (value->is_percentage())
@ -2985,11 +2969,11 @@ RefPtr<StyleValue> Parser::parse_single_background_position_value(TokenStream<Co
if (is_horizontal(identifier)) { if (is_horizontal(identifier)) {
bool offset_provided = false; bool offset_provided = false;
auto offset = try_parse_offset(offset_provided); auto offset = try_parse_offset(offset_provided);
horizontal = EdgeOffset { *identifier_to_edge(identifier), offset, true, offset_provided }; horizontal = EdgeOffset { *value_id_to_position_edge(identifier), offset, true, offset_provided };
} else if (is_vertical(identifier)) { } else if (is_vertical(identifier)) {
bool offset_provided = false; bool offset_provided = false;
auto offset = try_parse_offset(offset_provided); auto offset = try_parse_offset(offset_provided);
vertical = EdgeOffset { *identifier_to_edge(identifier), offset, true, offset_provided }; vertical = EdgeOffset { *value_id_to_position_edge(identifier), offset, true, offset_provided };
} else if (identifier == ValueID::Center) { } else if (identifier == ValueID::Center) {
found_center = true; found_center = true;
} else { } else {
@ -3068,7 +3052,7 @@ RefPtr<StyleValue> Parser::parse_single_background_position_x_or_y_value(TokenSt
transaction.commit(); transaction.commit();
return EdgeStyleValue::create(relative_edge, Percentage { 50 }); return EdgeStyleValue::create(relative_edge, Percentage { 50 });
} }
if (auto edge = identifier_to_edge(identifier); edge.has_value()) { if (auto edge = value_id_to_position_edge(identifier); edge.has_value()) {
relative_edge = *edge; relative_edge = *edge;
} else { } else {
return nullptr; return nullptr;