RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:38:10 +00:00
Code Issues Activity Actions

LibGUI: Unbreak clearing GTableView selection by clicking outside items.

Browse source 
Also, clicking on the column headers should not clear selection.
This commit is contained in:
Andreas Kling 2019-03-04 10:18:05 +01:00
parent ef4d517429
commit f91a20f9d0
2 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
LibGUI/GTableModel.h
View file

@ -54,11 +54,7 @@ public:
return index.row() >= 0 && index.row() < row_count() && index.column() >= 0 && index.column() < column_count(); return index.row() >= 0 && index.row() < row_count() && index.column() >= 0 && index.column() < column_count();
} }
void set_selected_index(const GModelIndex& index) void set_selected_index(const GModelIndex& index) { m_selected_index = index; }
{
if (is_valid(index))
m_selected_index = index;
}
GModelIndex selected_index() const { return m_selected_index; } GModelIndex selected_index() const { return m_selected_index; }
void register_view(Badge<GTableView>, GTableView&); void register_view(Badge<GTableView>, GTableView&);

5
LibGUI/GTableView.cpp
View file

@ -87,6 +87,11 @@ Rect GTableView::row_rect(int item_index) const
void GTableView::mousedown_event(GMouseEvent& event) void GTableView::mousedown_event(GMouseEvent& event)
{ {
if (event.y() < header_height()) {
// FIXME: Do something when clicking on a header.
return;
}
auto adjusted_position = event.position().translated(0, m_vertical_scrollbar->value()); auto adjusted_position = event.position().translated(0, m_vertical_scrollbar->value());
if (event.button() == GMouseButton::Left) { if (event.button() == GMouseButton::Left) {
for (int i = 0; i < item_count(); ++i) { for (int i = 0; i < item_count(); ++i) {