RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 18:05:07 +00:00
Code Issues Activity Actions

LibUnicode: Generate enum/alias from-string methods without a HashMap

Browse source 
The *_from_string() and resolve_*_alias() generated methods are the last
remaining users of HashMap in the LibUnicode generated files (read: the
last methods not using compile-time structures). This converts these
methods to use an array containing pairs of hash values to the desired
lookup value.

Because this code generation is the same between GenerateUnicodeData.cpp
and GenerateUnicodeLocale.cpp, this adds a GeneratorUtil.h header to the
LibUnicode generators to contain the method that generates the methods.
This commit is contained in:
Timothy Flynn 2021-10-12 12:22:47 -04:00 • committed by Andreas Kling
parent 203ee58aa2
commit f91d63af83
3 changed files with 120 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

68
Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp
View file

@ -4,6 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "GeneratorUtil.h"
#include <AK/AllOf.h>
#include <AK/CharacterTypes.h>
#include <AK/Format.h>
@ -666,7 +667,7 @@ static void generate_unicode_locale_implementation(Core::File& file, UnicodeLoca
generator.append(R"~~~(
#include <AK/Array.h>
#include <AK/HashMap.h>
#include <AK/BinarySearch.h>
#include <AK/Span.h>
#include <LibUnicode/Locale.h>
#include <LibUnicode/UnicodeLocale.h>
@ -1043,67 +1044,24 @@ Optional<StringView> get_locale_@enum_snake@_mapping(StringView locale, StringVi
)~~~");
};
auto append_from_string = [&](StringView enum_title, StringView enum_snake, Vector<String> const& values) {
generator.set("enum_title", enum_title);
generator.set("enum_snake", enum_snake);
auto append_from_string = [&](StringView enum_title, StringView enum_snake, auto const& values) {
HashValueMap<String> hashes;
hashes.ensure_capacity(values.size());
generator.append(R"~~~(
Optional<@enum_title@> @enum_snake@_from_string(StringView const& @enum_snake@)
{
static HashMap<StringView, @enum_title@> @enum_snake@_values { {)~~~");
for (auto const& value : values)
hashes.set(value.hash(), format_identifier(enum_title, value));
for (auto const& value : values) {
generator.set("key"sv, value);
generator.set("value"sv, format_identifier(enum_title, value));
generator.append(R"~~~(
{ "@key@"sv, @enum_title@::@value@ },)~~~");
}
generator.append(R"~~~(
} };
if (auto value = @enum_snake@_values.get(@enum_snake@); value.has_value())
return value.value();
return {};
}
)~~~");
generate_value_from_string(generator, "{}_from_string"sv, enum_title, enum_snake, move(hashes));
};
auto append_alias_search = [&](StringView enum_snake, auto const& aliases) {
generator.set("enum_snake", enum_snake);
HashValueMap<size_t> hashes;
hashes.ensure_capacity(aliases.size());
generator.append(R"~~~(
Optional<StringView> resolve_@enum_snake@_alias(StringView const& @enum_snake@)
{
static HashMap<StringView, size_t> @enum_snake@_aliases { {
)~~~");
for (auto const& alias : aliases)
hashes.set(alias.key.hash(), alias.value);
constexpr size_t max_values_per_row = 10;
size_t values_in_current_row = 0;
for (auto const& alias : aliases) {
if (values_in_current_row++ > 0)
generator.append(" ");
generator.set("key"sv, alias.key);
generator.set("alias"sv, String::number(alias.value));
generator.append("{ \"@key@\"sv, @alias@ },");
if (values_in_current_row == max_values_per_row) {
generator.append("\n ");
values_in_current_row = 0;
}
}
generator.append(R"~~~(
} };
if (auto alias = @enum_snake@_aliases.get(@enum_snake@); alias.has_value())
return s_string_list[alias.value()];
return {};
}
)~~~");
generate_value_from_string(generator, "resolve_{}_alias"sv, "size_t"sv, enum_snake, move(hashes), "StringView"sv, "s_string_list[{}]"sv);
};
append_from_string("Locale"sv, "locale"sv, locale_data.locales.keys());