RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:47:36 +00:00
Code Issues Activity Actions

Kernel: Remove big lock from sys$bind

Browse source 
This syscall doesn't access any unprotected shared data.
This commit is contained in:
Idan Horowitz 2022-04-09 22:41:31 +03:00 • committed by Andreas Kling
parent 2c025d6334
commit f986a3b886
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -47,7 +47,7 @@ enum class NeedsBigProcessLock {
S(allocate_tls, NeedsBigProcessLock::Yes) \ S(allocate_tls, NeedsBigProcessLock::Yes) \
S(anon_create, NeedsBigProcessLock::No) \ S(anon_create, NeedsBigProcessLock::No) \
S(beep, NeedsBigProcessLock::No) \ S(beep, NeedsBigProcessLock::No) \
S(bind, NeedsBigProcessLock::Yes) \ S(bind, NeedsBigProcessLock::No) \
S(chdir, NeedsBigProcessLock::No) \ S(chdir, NeedsBigProcessLock::No) \
S(chmod, NeedsBigProcessLock::No) \ S(chmod, NeedsBigProcessLock::No) \
S(chown, NeedsBigProcessLock::Yes) \ S(chown, NeedsBigProcessLock::Yes) \

2
Kernel/Syscalls/socket.cpp
View file

@ -50,7 +50,7 @@ ErrorOr<FlatPtr> Process::sys$socket(int domain, int type, int protocol)
ErrorOr<FlatPtr> Process::sys$bind(int sockfd, Userspace<sockaddr const*> address, socklen_t address_length) ErrorOr<FlatPtr> Process::sys$bind(int sockfd, Userspace<sockaddr const*> address, socklen_t address_length)
{ {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) VERIFY_NO_PROCESS_BIG_LOCK(this)
auto description = TRY(open_file_description(sockfd)); auto description = TRY(open_file_description(sockfd));
if (!description->is_socket()) if (!description->is_socket())
return ENOTSOCK; return ENOTSOCK;