RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:17:45 +00:00
Code Issues Activity Actions

Kernel: Make sure OpenFileDescription is kept alive while read() blocks

Browse source 
It's not safe to store OpenFileDescription in a raw pointer when
blocking, since another thread may decide to close the corresponding
file descriptor.
This commit is contained in:
Andreas Kling 2021-11-21 20:03:11 +01:00
parent 401c9415b4
commit f99af1bef0
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Syscalls/read.cpp
View file

@ -12,7 +12,7 @@ namespace Kernel {
using BlockFlags = Thread::FileBlocker::BlockFlags; using BlockFlags = Thread::FileBlocker::BlockFlags;
static ErrorOr<OpenFileDescription*> open_readable_file_description(Process::OpenFileDescriptions const& fds, int fd) static ErrorOr<NonnullRefPtr<OpenFileDescription>> open_readable_file_description(Process::OpenFileDescriptions const& fds, int fd)
{ {
auto description = TRY(fds.open_file_description(fd)); auto description = TRY(fds.open_file_description(fd));
if (!description->is_readable()) if (!description->is_readable())