RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

LibPDF: Do not crash when linearized length is incorrect

Browse source 
This is a perfectly valid situation, and in this case we should just
parse a standard non-linearized xref table.
This commit is contained in:
Matthew Olsson 2023-07-16 03:44:56 -07:00 • committed by Jelle Raaijmakers
parent e5a6c268ca
commit f9c1d11380
1 changed files with 3 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibPDF/DocumentParser.cpp
View file

@ -43,16 +43,10 @@ PDFErrorOr<Version> DocumentParser::initialize()
bool is_linearized = m_linearization_dictionary.has_value();
if (is_linearized) {
// The file may have been linearized at one point, but could have been updated afterwards,
// which means it is no longer a linearized PDF file.
// If the length given in the linearization dictionary is not equal to the length
// of the document, then this file has most likely been incrementally updated, and
// should no longer be treated as linearized.
is_linearized = m_linearization_dictionary.value().length_of_file == m_reader.bytes().size();
if (!is_linearized) {
// FIXME: The file shouldn't be treated as linearized, yet the xref tables are still
// split. This might take some tweaking to ensure correct behavior, which can be
// implemented later.
TODO();
}
}
if (is_linearized)