RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 20:57:35 +00:00
Code Issues Activity Actions

LibWeb: Only propagate CSS overflow to the viewport once per tree build

Browse source 
Before this change, we were doing it after every layout, which meant
that already-propagated overflow could be propagated again, which led to
incorrect scrolling behavior.
This commit is contained in:
Andreas Kling 2023-11-02 20:08:02 +01:00
parent bc6f19da0e
commit f9cab320e6
5 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Layout/expected/replaced-within-max-content.txt
View file

@ -8,7 +8,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
frag 0 from ImageBox start: 0, length: 0, rect: [8,8 150x150]
ImageBox <img.replaced> at (8,8) content-size 150x150 children: not-inline
(SVG-as-image isolated context)
Viewport <#document> at (0,0) content-size 150x150 children: inline
Viewport <#document> at (0,0) content-size 150x150 [BFC] children: inline
SVGSVGBox <svg> at (0,0) content-size 150x150 [SVG] children: not-inline
SVGGeometryBox <path> at (0,0) content-size 150x150 children: not-inline
TextNode <#text>

2
Tests/LibWeb/Layout/expected/svg/svg-as-image-implicit-viewbox.txt
View file

@ -3,7 +3,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <body> at (8,8) content-size 784x100 children: not-inline
ImageBox <img> at (8,8) content-size 50x100 children: not-inline
(SVG-as-image isolated context)
Viewport <#document> at (0,0) content-size 50x100 children: inline
Viewport <#document> at (0,0) content-size 50x100 [BFC] children: inline
SVGSVGBox <svg> at (0,0) content-size 50x100 [SVG] children: not-inline
SVGGeometryBox <rect> at (0,0) content-size 50x100 children: not-inline

2
Tests/LibWeb/Layout/expected/svg/svg-as-image.txt
View file

@ -3,7 +3,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <body> at (8,8) content-size 784x1568 children: not-inline
ImageBox <img> at (8,8) content-size 784x1568 children: not-inline
(SVG-as-image isolated context)
Viewport <#document> at (0,0) content-size 784x1568 children: inline
Viewport <#document> at (0,0) content-size 784x1568 [BFC] children: inline
SVGSVGBox <svg> at (0,0) content-size 784x1568 [SVG] children: inline
TextNode <#text>
SVGGeometryBox <rect> at (0,0) content-size 784x1568 children: not-inline